From b8fb6769c78e4bc4cddace49d529fd00533a9b43 Mon Sep 17 00:00:00 2001
From: Matthew L McPeak <m.mcpeak98@icloud.com>
Date: Mon, 13 Jul 2026 18:39:31 -0400
Subject: [PATCH] fix: stop unregistering Select item labels on unmount

SelectItem removed its entry from the shared itemLabels map on
unmount, which fires for every item when the dropdown closes --
including the item that was just selected. That wiped the trigger's
display label right after selecting (and after Escape/close in
general). Labels only need to be learned once and can safely persist,
matching the documented behavior in tests/Select.spec.ts. Found via
manual Storybook verification.
---
 packages/library/src/components/ui/select/Select.vue     | 1 -
 packages/library/src/components/ui/select/SelectItem.vue | 5 +----
 packages/library/src/components/ui/select/context.ts     | 1 -
 3 files changed, 1 insertion(+), 6 deletions(-)

diff --git a/packages/library/src/components/ui/select/Select.vue b/packages/library/src/components/ui/select/Select.vue
index bf60823..35fc74a 100644
--- a/packages/library/src/components/ui/select/Select.vue
+++ b/packages/library/src/components/ui/select/Select.vue
@@ -37,7 +37,6 @@ provide(SelectContextKey, {
   contentId: `select-content-${useId()}`,
   itemLabels,
   registerLabel: (value: string, label: string) => { itemLabels.set(value, label) },
-  unregisterLabel: (value: string) => { itemLabels.delete(value) },
 })
 </script>
 
diff --git a/packages/library/src/components/ui/select/SelectItem.vue b/packages/library/src/components/ui/select/SelectItem.vue
index f8dbb51..d2b7525 100644
--- a/packages/library/src/components/ui/select/SelectItem.vue
+++ b/packages/library/src/components/ui/select/SelectItem.vue
@@ -1,7 +1,7 @@
 <script setup lang="ts">
 import { CheckIcon } from '@lucide/vue'
 import type { HTMLAttributes } from 'vue'
-import { computed, inject, onBeforeUnmount, onMounted, ref } from 'vue'
+import { computed, inject, onMounted, ref } from 'vue'
 import { cn } from '@/lib/utils'
 import { SelectContextKey } from './context'
 import SelectItemText from './SelectItemText.vue'
@@ -31,9 +31,6 @@ function onPointerMove() {
 onMounted(() => {
   context.registerLabel(props.value, itemRef.value?.textContent?.trim() ?? '')
 })
-onBeforeUnmount(() => {
-  context.unregisterLabel(props.value)
-})
 </script>
 
 <template>
diff --git a/packages/library/src/components/ui/select/context.ts b/packages/library/src/components/ui/select/context.ts
index e99fcd4..190e7bf 100644
--- a/packages/library/src/components/ui/select/context.ts
+++ b/packages/library/src/components/ui/select/context.ts
@@ -8,7 +8,6 @@ export interface SelectContext {
   contentId: string
   itemLabels: Map<string, string>
   registerLabel: (value: string, label: string) => void
-  unregisterLabel: (value: string) => void
 }
 
 export const SelectContextKey: InjectionKey<SelectContext> = Symbol('SelectContext')